Change in vdsm[master]: Adding getBiosInfo API to vdsm cli and merge bios informatio...

bazulay at redhat.com bazulay at redhat.com
Mon Dec 24 14:38:24 UTC 2012


Barak Azulay has posted comments on this change.

Change subject: Adding getBiosInfo API to vdsm cli and merge bios information with vdsGetCaps
......................................................................


Patch Set 14: (3 inline comments)

....................................................
File vdsm/API.py
Line 1122:         """
Line 1123:         Report host capabilities.
Line 1124:         """
Line 1125:         c = caps.get()
Line 1126:         c['bios'] = self.getBiosInfo()['info']
The above line is not relevant in case the engine's implementation actually uses the getHostBios API explicitly
Line 1127:         c['netConfigDirty'] = str(self._cif._netConfigDirty)
Line 1128: 
Line 1129:         return {'status': doneCode, 'info': c}
Line 1130: 


....................................................
File vdsm_api/vdsmapi-schema.json
Line 867: #
Line 868: # @cpuThreads:          The number of CPU threads present
Line 869: #
Line 870: # @biosInfo:            Host bios information
Line 871: #
The above line is not relevant in case the engine's implementation actually uses the getHostBios API explicitly
Line 872: # @cpuCores:            The number of CPU cores present
Line 873: #
Line 874: # @cpuSockets:          The numbet of CPU sockets
Line 875: #


Line 930: #        the current API truncates @software_version to 'x.y'.
Line 931: ##
Line 932: {'type': 'VdsmCapabilities',
Line 933:  'data': {'kvmEnabled': 'bool', 'cpuThreads': 'uint',
Line 934:           'biosInfo': 'BiosInformation', 'cpuCores': 'uint',
The above biosInfo is not relevant in case the engine's implementation actually uses the getHostBios API explicitly
Line 935:           'cpuSockets': 'uint', 'cpuSpeed': 'float', 'cpuModel': 'str',
Line 936:           'cpuFlags': 'str', 'version_name': 'str', 'software_version': 'str',
Line 937:           'software_revision': 'str', 'supportedENGINEs': ['str'],
Line 938:           'supportedProtocols': ['str'], 'clusterLevels': ['str'],


--
To view, visit http://gerrit.ovirt.org/9258
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic429ef101fcf9047c4b552405314dc7ba9ba07a0
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Andrew Cathrow <andrew at cathrow.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Pradipta Banerjee <bpradip at in.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list