Change in vdsm[master]: fix prepareVolumePath: BZ#843387, BZ#872961

abaron at redhat.com abaron at redhat.com
Mon Dec 24 08:49:30 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: fix prepareVolumePath: BZ#843387, BZ#872961
......................................................................


Patch Set 8: Looks good to me, approved

(1 inline comment)

....................................................
File vdsm/clientIF.py
Line 289:             elif "UUID" in drive:
Line 290:                 volPath = self._getUUIDSpecPath(drive["UUID"])
Line 291: 
Line 292:             # leave path == '' for empty cdrom and floppy drives ...
Line 293:             elif drive['device'] in ('cdrom', 'floppy') and \
it's a style issue so I won't block on it but why not:
specParams = drive['device'] in ('cdrom', 'floppy') and 'specParams' in drive

and then:  elif specParams and ...
Line 294:                     'specParams' in drive and \
Line 295:                     'path' in drive['specParams'] and \
Line 296:                     drive['specParams']['path'] == '':
Line 297:                         volPath = ''


--
To view, visit http://gerrit.ovirt.org/6803
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d5b36a88752ad2191226191c9502c1717033bbc
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list