Change in vdsm[ovirt-3.2]: caps.py: osversion() validate OVIRT

Haim Ateya hateya at redhat.com
Sun Dec 23 15:13:38 UTC 2012


Haim Ateya has posted comments on this change.

Change subject: caps.py: osversion() validate OVIRT
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/caps.py
Line 228:     version = release = ''
Line 229: 
Line 230:     osname = getos()
Line 231:     try:
Line 232:         if osname == OSName.RHEVH or osname == OSName.OVIRT:
why not use tuple? if osname in (OSName.RHEVH,OSName.OVIRT)
Line 233:             d = _parseKeyVal(file('/etc/default/version'))
Line 234:             version = d.get('VERSION', '')
Line 235:             release = d.get('RELEASE', '')
Line 236:         elif osname == OSName.DEBIAN:


--
To view, visit http://gerrit.ovirt.org/10177
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58efd4660f94b2f68ead470a54f0f301a1b9b4ba
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.2
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>


More information about the vdsm-patches mailing list