Change in vdsm[master]: catch libvirt timeout and return an error on setVmTicket

rgolan at redhat.com rgolan at redhat.com
Sun Dec 23 09:56:21 UTC 2012


Roy Golan has posted comments on this change.

Change subject: catch libvirt timeout and return an error on setVmTicket
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/API.py
Line 575:         except KeyError:
Line 576:             return errCode['noVM']
Line 577:         except TimeoutError as tmo:
Line 578:             err = errCode['internalVdsmTimeout']
Line 579:             err['exception'] = tmo
indeed, ovirt engine. its for better error handling/reporting. you can refer to the bz in the comment.
Line 580:             return err
Line 581: 
Line 582:     def shutdown(self, delay=None, message=None):
Line 583:         """


--
To view, visit http://gerrit.ovirt.org/10285
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb48a1baff1e059f48f71f600f4bf5d9f40a7d11
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list