Change in vdsm[master]: restarting libvirtd didn't work over allinone setup

ybronhei at redhat.com ybronhei at redhat.com
Sun Dec 23 08:45:35 UTC 2012


Hello Ohad Basan, Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/10312

to review the following change.

Change subject: restarting libvirtd didn't work over allinone setup
......................................................................

restarting libvirtd didn't work over allinone setup

Change-Id: I13cbe3cd91cb9eb7f22135f6a0ae6f0391b46ae4
Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=888258
Signed-off-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/10237
Tested-by: Ohad Basan <obasan at redhat.com>
Reviewed-by: Ohad Basan <obasan at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/vdsmd.init.in
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/10312/1

diff --git a/vdsm/vdsmd.init.in b/vdsm/vdsmd.init.in
index 7a7ae84..c8223d3 100755
--- a/vdsm/vdsmd.init.in
+++ b/vdsm/vdsmd.init.in
@@ -362,7 +362,11 @@
 
     ovirt_store_config "$lconf" "$qconf" "$ldconf" "$llogr"
 
-    /sbin/initctl restart libvirtd 2>/dev/null || :
+    if libvirt_should_use_upstart; then
+        /sbin/initctl restart libvirtd 2>/dev/null || :
+    else
+        /bin/systemctl restart libvirtd.service
+    fi
 
     #
     # finished reconfiguration, do not trigger


--
To view, visit http://gerrit.ovirt.org/10312
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I13cbe3cd91cb9eb7f22135f6a0ae6f0391b46ae4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan at redhat.com>


More information about the vdsm-patches mailing list