Change in vdsm[ovirt-3.2]: api: Report CPU thread info in getVdsCapabilities

dfediuck at redhat.com dfediuck at redhat.com
Fri Dec 21 08:46:38 UTC 2012


Hello Greg Padgett,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/10300

to review the following change.

Change subject: api: Report CPU thread info in getVdsCapabilities
......................................................................

api: Report CPU thread info in getVdsCapabilities

Report CPU thread info in getVdsCapabilities

Change-Id: I11f1e139a3f3d5bd18032713694bdebf9ab8c1d7
Signed-off-by: Greg Padgett <gpadgett at redhat.com>
---
M vdsm/caps.py
M vdsm_api/vdsmapi-schema.json
2 files changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/10300/1

diff --git a/vdsm/caps.py b/vdsm/caps.py
index 0438fb4..6749227 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -261,6 +261,7 @@
     else:
         caps['cpuCores'] = str(cpuTopology.cores())
 
+    caps['cpuThreads'] = str(cpuTopology.threads())
     caps['cpuSockets'] = str(cpuTopology.sockets())
     caps['cpuSpeed'] = cpuInfo.mhz()
     if config.getboolean('vars', 'fake_kvm_support'):
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index 58dd6e2..c72ec4b 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -848,6 +848,8 @@
 #
 # @kvmEnabled:          KVM is enabled on the host
 #
+# @cpuThreads:          The number of CPU threads present
+#
 # @cpuCores:            The number of CPU cores present
 #
 # @cpuSockets:          The numbet of CPU sockets
@@ -909,7 +911,7 @@
 #        the current API truncates @software_version to 'x.y'.
 ##
 {'type': 'VdsmCapabilities',
- 'data': {'kvmEnabled': 'bool', 'cpuCores': 'uint',
+ 'data': {'kvmEnabled': 'bool', 'cpuThreads': 'uint', 'cpuCores': 'uint',
           'cpuSockets': 'uint', 'cpuSpeed': 'float', 'cpuModel': 'str',
           'cpuFlags': 'str', 'version_name': 'str', 'software_version': 'str',
           'software_revision': 'str', 'supportedENGINEs': ['str'],


--
To view, visit http://gerrit.ovirt.org/10300
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I11f1e139a3f3d5bd18032713694bdebf9ab8c1d7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.2
Gerrit-Owner: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>


More information about the vdsm-patches mailing list