Change in vdsm[master]: Improve dom xml gereration

vfeenstr at redhat.com vfeenstr at redhat.com
Fri Dec 21 07:51:56 UTC 2012


Vinzenz Feenstra has posted comments on this change.

Change subject: Improve dom xml gereration
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 595:         self.log = log
Line 596: 
Line 597:         self.doc = xml.dom.minidom.Document()
Line 598:         domType = ('kvm' if utils.tobool(self.conf.get('kvmEnable', 'true'))
Line 599:                    else 'qemu')
good point +1 on that
Line 600:         self.dom = XMLElem('domain', attrs={'type': domType})
Line 601:         self.doc.appendChild(self.dom)
Line 602: 
Line 603:         self.dom.addChild('name', text=self.conf['vmName'])


--
To view, visit http://gerrit.ovirt.org/10054
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib936740fcbeeee551e13abfed7fd91f2a159e351
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list