Change in vdsm[master]: Add some more tests to JsonRpcTests

smizrahi at redhat.com smizrahi at redhat.com
Wed Dec 19 21:35:36 UTC 2012


Saggi Mizrahi has uploaded a new change for review.

Change subject: Add some more tests to JsonRpcTests
......................................................................

Add some more tests to JsonRpcTests

Change-Id: I1167f65203fbed653d876408be8137f505ab68d9
Signed-off-by: Saggi Mizrahi <smizrahi at redhat.com>
---
M tests/jsonRpcTests.py
1 file changed, 14 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/10254/1

diff --git a/tests/jsonRpcTests.py b/tests/jsonRpcTests.py
index c79656f..376b630 100644
--- a/tests/jsonRpcTests.py
+++ b/tests/jsonRpcTests.py
@@ -295,6 +295,9 @@
     def echo(self, text):
         return text
 
+    def ping(self):
+        return None
+
 
 @expandPermutations
 class JsonRpcServerTests(TestCaseBase):
@@ -353,3 +356,14 @@
 
                 self.assertEquals(cm.exception.code,
                                   JsonRpcInternalError().code)
+
+    @permutations(REACTOR_TYPE_PERMUTATIONS)
+    def testMethodReturnsNull(self, reactorType):
+        bridge = _DummyBridge()
+        with constructServer(reactorType, bridge) as (server, clientFactory):
+            client = clientFactory()
+            client.connect()
+            with closing(client):
+                res = client.callMethod("ping", [], 10, timeout=CALL_TIMEOUT)
+
+                self.assertEquals(res, None)


--
To view, visit http://gerrit.ovirt.org/10254
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1167f65203fbed653d876408be8137f505ab68d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list