Change in vdsm[master]: Handling removing file Exceptions.

danken at redhat.com danken at redhat.com
Wed Dec 19 09:49:07 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Handling removing file Exceptions.
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/utils.py
Line 63:     except OSError as e:
Line 64:         if e.errno == errno.ENOENT:
Line 65:             logging.warning("File: %s already removed", fileToRemove)
Line 66:         else:
Line 67:             logging.error("Removing file: %s failed", fileToRemove,
this log is pointless as it would be logged again when the re-raised exception is caught.

if for some reason you want to keep, please fix the pep8 indentation here, or this would break build on f18.
Line 68:                                                             exc_info=True)
Line 69:             raise
Line 70: 
Line 71: def readMemInfo():


--
To view, visit http://gerrit.ovirt.org/8625
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If76e158ad69921d382e3d42ae45486534b9379f9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list