Change in vdsm[master]: Starting svdsm on startup

lvroyce at linux.vnet.ibm.com lvroyce at linux.vnet.ibm.com
Wed Dec 19 08:01:45 UTC 2012


Royce Lv has posted comments on this change.

Change subject: Starting svdsm on startup
......................................................................


Patch Set 2: I would prefer that you didn't submit this

On vdsm restart, __init__ it does not have member "_svdsm", "_svdsm" only create on "launch" so if old svdsm exists, vdsm will not communicate with the old one, because it does not has the manager instance. In this case call will return:NameError: global name '_svdsm' is not defined

--
To view, visit http://gerrit.ovirt.org/9691
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iebee1b4fbb62f3760609d12d694f466dc9379fca
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list