Change in vdsm[master]: Don't fail silently when ifup fails.

danken at redhat.com danken at redhat.com
Tue Dec 18 22:13:29 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Don't fail silently when ifup fails.
......................................................................


Patch Set 16: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 355:         for dev in reversed(self._sortModifiedIfcfgs()):
Line 356:             ifdown(dev)
Line 357: 
Line 358:     def _startAtomicDevices(self):
Line 359:         for dev in self._sortModifiedIfcfgs():
we need to catch the new exception here, to keep our "best effort" semantics for the rollback operation.
Line 360:             ifup(dev)
Line 361: 
Line 362:     @classmethod
Line 363:     def _persistentBackup(cls, filename):


--
To view, visit http://gerrit.ovirt.org/8415
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cc9dcc0a6b55d36fc937e1d364bd9c256ecd70a
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list