Change in vdsm[master]: Fix miscTests:ExecCmd.testNice failing due to race

smizrahi at redhat.com smizrahi at redhat.com
Tue Dec 18 17:05:34 UTC 2012


Saggi Mizrahi has uploaded a new change for review.

Change subject: Fix miscTests:ExecCmd.testNice failing due to race
......................................................................

Fix miscTests:ExecCmd.testNice failing due to race

Change-Id: I9df2a3b437fe1eb380beebf10ef049f2d49104a6
Signed-off-by: Saggi Mizrahi <smizrahi at redhat.com>
---
M tests/miscTests.py
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/10207/1

diff --git a/tests/miscTests.py b/tests/miscTests.py
index f54907f..cfa2f90 100644
--- a/tests/miscTests.py
+++ b/tests/miscTests.py
@@ -1037,8 +1037,12 @@
     def testNice(self):
         cmd = ["sleep", "10"]
         proc = misc.execCmd(cmd, sudo=False, nice=10, sync=False)
-        nice = misc.pidStat(proc.pid)[18]
-        self.assertEquals(nice, 10)
+
+        def test():
+            nice = misc.pidStat(proc.pid)[18]
+            self.assertEquals(nice, 10)
+
+        utils.retry(AssertionError, test, tries=10, sleep=0.1)
         proc.kill()
         proc.wait()
 


--
To view, visit http://gerrit.ovirt.org/10207
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9df2a3b437fe1eb380beebf10ef049f2d49104a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list