Change in vdsm[master]: Integrate Smartcard support

peet at redhat.com peet at redhat.com
Tue Dec 18 16:44:06 UTC 2012


Peter V. Saveliev has posted comments on this change.

Change subject: Integrate Smartcard support
......................................................................


Patch Set 17: (2 inline comments)

....................................................
File vdsm_api/vdsmapi-schema.json
Line 2425:           'pid': 'uint', 'smp': 'uint', '*smpCoresPerSocket': 'uint',
Line 2426:           '*smpThreadsPerCore': 'uint', 'status': 'VmStatus',
Line 2427:           'timeOffset': 'uint', 'transparentHugePages': 'bool',
Line 2428:           'vmId': 'UUID', 'vmName': 'str', 'vmType': 'VmType',
Line 2429:           'smartcard': 'bool'}}
Done
Line 2430: 
Line 2431: ##
Line 2432: # @VmParameters:
Line 2433: #


....................................................
File vdsm/libvirtvm.py
Line 2654:                 if dev['device'] == vm.SMARTCARD_DEVICES and \
Line 2655:                         not dev.get('address'):
Line 2656:                     dev['address'] = address
Line 2657:                     dev['alias'] = alias
Line 2658: 
Done
Line 2659:     def _getUnderlyingWatchdogDeviceInfo(self):
Line 2660:         """
Line 2661:         Obtain watchdog device info from libvirt.
Line 2662:         """


--
To view, visit http://gerrit.ovirt.org/8450
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cdaef420c8381d588f6215e66e6a80dd9d2e44b
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list