Change in vdsm[master]: Check if log file exist on startup and log directory is acce...

smizrahi at redhat.com smizrahi at redhat.com
Tue Dec 18 15:28:49 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: Check if log file exist on startup and log directory is accessible
......................................................................


Patch Set 2: I would prefer that you didn't submit this

It don't understand what you are doing.
Shouldn't you make sure all log files are writable (for rotate).
Just use glob

--
To view, visit http://gerrit.ovirt.org/10194
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I300adc5ac3d9b12fee49023a54e5ffb4dee98da1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list