Change in vdsm[master]: Adding getBiosInfo API to vdsm cli and merge bios informatio...

smizrahi at redhat.com smizrahi at redhat.com
Tue Dec 18 15:25:40 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: Adding getBiosInfo API to vdsm cli and merge bios information with vdsGetCaps
......................................................................


Patch Set 12: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/dmidecodeUtil.py
Line 23: 
Line 24: 
Line 25: def __leafDict(d, n):
Line 26:     for k in d:
Line 27:         if type(d[k]) == dict:
It should actually be isinstance(d[k], dict)
Line 28:             __leafDict(d[k], n)
Line 29:         else:
Line 30:             n[k] = d[k]
Line 31: 


--
To view, visit http://gerrit.ovirt.org/9258
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic429ef101fcf9047c4b552405314dc7ba9ba07a0
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Andrew Cathrow <andrew at cathrow.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list