Change in vdsm[master]: Starting svdsm on startup

danken at redhat.com danken at redhat.com
Mon Dec 17 21:26:23 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Starting svdsm on startup
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

I am a bit confused. In http://gerrit.ovirt.org/7901 you have removed self._restartSupervdsm() from __init__(), and now you add it. Could you explain - in the commit message - what went wrong back then?

I hate running in circles, and since you've convinced me that c#7901 was right, I would now ask you to unconvince me...

....................................................
Commit Message
Line 6: 
Line 7: Starting svdsm on startup
Line 8: 
Line 9: When prepareForShutdown is invoked vdsm restarts itself, when this
Line 10: haapens super vdsm supposed also to restart itself after the old instance dies.
English: "when" appears twice in a single sentence. haapens -> happens.
Line 11: Apparently, this happens too fast, and until the old instance dies, vdsm
Line 12: tries to communicate with it and fails, and only then svdsm initiates the new
Line 13: instance.
Line 14: This patch initiates svdsm during vdsm startup instead of during the first


....................................................
File vdsm/supervdsm.py
Line 95:         # vdsm process. If firstRun is false, internal files must exist.
Line 96:         # Otherwise, if somehow svdsm's internal files has been
Line 97:         # changed or deleted we need to raise an exception.
Line 98:         # This case is handled in isRunning scope.
Line 99:         self._firstRun = True
the swapping of these two lines is meaningless - except for its power to confuse me.

please avoid such changes withing a delicate fix like this one.
Line 100: 
Line 101:         self.proxyLock = threading.Lock()
Line 102:         # Declaration of public variables that keep files' names that svdsm
Line 103:         # uses. We need to be able to change these variables so that running


--
To view, visit http://gerrit.ovirt.org/9691
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iebee1b4fbb62f3760609d12d694f466dc9379fca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list