Change in vdsm[master]: Fix configNetworkTests.ConfigWriter monkeypatch.

danken at redhat.com danken at redhat.com
Mon Dec 17 21:00:19 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Fix configNetworkTests.ConfigWriter monkeypatch.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

Could you tell why we have NET_CONF_PREF defined twice? Once in netinfo.NET_CONF_PREF, and another in configNetwork.ConfigWriter.NET_CONF_PREF ?

A proper monkeypatch should change both; a proper code should have only one.

Also, please say in the commit message, why current monkey patching is insufficient.

--
To view, visit http://gerrit.ovirt.org/10161
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6925c59650aaa81fa925a4be3bcd72dcbebbb415
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list