Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm

vfeenstr at redhat.com vfeenstr at redhat.com
Mon Dec 17 14:41:59 UTC 2012


Vinzenz Feenstra has posted comments on this change.

Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm
......................................................................


Patch Set 3:

The point is that we're not supporting anything but libvirt, and therefore, there's no real reason to have this split up. Having this separated will make the upcoming need for refactoring the Vm and LibvirtVm classes into one, just harder.

I understand your concern, however you quoted exactly the reasoning by Gal, why it would be best to implement all of this into one class and split it between libvirtvm and vm.

--
To view, visit http://gerrit.ovirt.org/9655
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86977c1b717d63de21ba4818c6b66e43976d65de
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Bing Bu Cao <mars at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list