Change in vdsm[master]: Remove redundant vlan device deletion.

asegurap at redhat.com asegurap at redhat.com
Wed Dec 12 17:26:08 UTC 2012


Antoni Segura Puimedon has uploaded a new change for review.

Change subject: Remove redundant vlan device deletion.
......................................................................

Remove redundant vlan device deletion.

ifdown-eth has a clause that on ifdown of a vlan interface, said
interface is deleted using ip link delete xxx type vlan. That
happens synchronously and just one line before we do the deletion
ourselves and generates a lot of FAILED messages in vdsm.log.

Change-Id: I3b9b6aea80ad372363aa54e3d4173ab2c1f8af7e
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
---
M vdsm/configNetwork.py
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/10008/1

diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py
index e6daa68..711a0d4 100755
--- a/vdsm/configNetwork.py
+++ b/vdsm/configNetwork.py
@@ -558,7 +558,6 @@
     def removeVlan(self, vlan, iface):
         vlandev = iface + '.' + vlan
         ifdown(vlandev)
-        execCmd([constants.EXT_IPROUTE, 'link', 'del', vlandev])
         self._backup(self.NET_CONF_PREF + iface + '.' + vlan)
         self._removeFile(self.NET_CONF_PREF + iface + '.' + vlan)
 


--
To view, visit http://gerrit.ovirt.org/10008
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b9b6aea80ad372363aa54e3d4173ab2c1f8af7e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>


More information about the vdsm-patches mailing list