Change in vdsm[master]: Fix pep8 completely for API.py

danken at redhat.com danken at redhat.com
Wed Dec 12 13:18:59 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Fix pep8 completely for API.py
......................................................................


Patch Set 1: Looks good to me, approved

(2 inline comments)

two minor comments that can wait for a future patch.

....................................................
File vdsm/API.py
Line 161:                         with file(fname) as f:
Line 162:                             pickledMachineParams = pickle.load(f)
Line 163: 
Line 164:                         if type(pickledMachineParams) == dict:
Line 165:                             self.log.debug('loaded pickledMachineParams '
better put the "+" operator on the opening line.
Line 166:                                            + str(pickledMachineParams))
Line 167:                             self.log.debug('former conf ' + str(vmParams))
Line 168:                             vmParams.update(pickledMachineParams)
Line 169:                     finally:


Line 226: 
Line 227:             if vmParams.get('display') not in ('vnc', 'qxl', 'qxlnc'):
Line 228:                 return {'status': {'code': errCode['createErr']
Line 229:                                                   ['status']['code'],
Line 230:                                    'message': 'Unknown display type %s'
here, too.
Line 231:                                               % vmParams.get('display')}}
Line 232:             if 'nicModel' not in vmParams:
Line 233:                 vmParams['nicModel'] = config.get('vars', 'nic_model')
Line 234:             vmParams['displayIp'] = self._getNetworkIp(vmParams.get(


--
To view, visit http://gerrit.ovirt.org/9993
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0369524e6f2476136c40678ddac3cda336f9a54b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list