Change in vdsm[master]: Fix flake8 warnings for network code.

asegurap at redhat.com asegurap at redhat.com
Wed Dec 12 09:28:07 UTC 2012


Antoni Segura Puimedon has posted comments on this change.

Change subject: Fix flake8 warnings for network code.
......................................................................


Patch Set 1: (1 inline comment)

I'll check that and add these files to the pep8 whitelist.

....................................................
File vdsm/configNetwork.py
Line 795:     if bonding and implicitBonding:
Line 796:         pass
Line 797:     elif (vlan or bonding) and not nics:
Line 798:         raise ConfigNetworkError(ne.ERR_BAD_PARAMS, 'vlan/bonding definition '
Line 799:                                  'requires nics. got: %r' % (nics,))
I don't know, I'll check.
Line 800: 
Line 801:     # Check bridge
Line 802:     if bridged:
Line 803:         validateBridgeName(network)


--
To view, visit http://gerrit.ovirt.org/9846
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59cd4d8bb41c1ce71b91b45ff7fe2f10f25eb577
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list