Change in vdsm[master]: Allow to remove NIC if it not in use

ilvovsky at redhat.com ilvovsky at redhat.com
Wed Dec 12 07:24:13 UTC 2012


Igor Lvovsky has posted comments on this change.

Change subject: Allow to remove NIC if it not in use
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 1103: 
Line 1104:     nic = nics[0] if nics else None
Line 1105:     iface = bonding if bonding else nic
Line 1106:     if iface:
Line 1107:         ifdown(iface)
:) I knew you will asked me and wanted to comment in gerrit by myself, but forgot it.
the answer is yes, this is intentionally.
we need ifdown/ifup for both cases VLANed and not-VLANed , otherwise the iface under vlan doesn't get it's new ifcfg configuration (MTU changes)
This make all our tests pass properly.
Line 1108:         if vlan:
Line 1109:             configWriter.removeVlan(vlan, iface)
Line 1110:         else:
Line 1111:             cf = configWriter.NET_CONF_PREF + iface


--
To view, visit http://gerrit.ovirt.org/9508
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb8e5fce14fc38c3df9c0b12dc4077726436807e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list