Change in vdsm[master]: Integrate Smartcard support

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Tue Dec 11 15:13:12 UTC 2012


Michal Skrivanek has posted comments on this change.

Change subject: Integrate Smartcard support
......................................................................


Patch Set 17: Looks good to me, but someone else must approve

(3 inline comments)

....................................................
File vdsm/libvirtvm.py
Line 1188:         """
Line 1189:         Add smartcard section to domain xml
Line 1190: 
Line 1191:         <smartcard mode='passthrough' type='spicevmc'>
Line 1192:           <address ... />
doc says "Each mode supports an optional sub-element <address>"
Line 1193:         </smartcard>
Line 1194:         """
Line 1195:         card = self.createXmlElem(self.device, None, ['address'])
Line 1196:         card.setAttribute('mode', self.specParams['mode'])


Line 1193:         </smartcard>
Line 1194:         """
Line 1195:         card = self.createXmlElem(self.device, None, ['address'])
Line 1196:         card.setAttribute('mode', self.specParams['mode'])
Line 1197:         card.setAttribute('type', self.specParams['type'])
we do not plan to support anything else but spicevmc.
Line 1198:         return card
Line 1199: 
Line 1200: 
Line 1201: class RedirDevice(LibvirtVmDevice):


....................................................
File vdsm/vm.py
Line 553:         cards = []
Line 554:         if self.conf.get('smartcard'):
Line 555:             cards.append({'device': SMARTCARD_DEVICES,
Line 556:                           'specParams': {'mode': 'passthrough',
Line 557:                                          'type': 'spicevmc'}})
passthrough/spicevmc is the only thing we ever want to support. Other modes make sense for virsh use cases but I don't see them relevant in cloud
Line 558:         return cards
Line 559: 
Line 560:     def getConfSound(self):
Line 561:         """


--
To view, visit http://gerrit.ovirt.org/8450
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cdaef420c8381d588f6215e66e6a80dd9d2e44b
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list