Change in vdsm[master]: Integrate Smartcard support

vfeenstr at redhat.com vfeenstr at redhat.com
Tue Dec 11 13:51:53 UTC 2012


Vinzenz Feenstra has posted comments on this change.

Change subject: Integrate Smartcard support
......................................................................


Patch Set 17: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 1193:         </smartcard>
Line 1194:         """
Line 1195:         card = self.createXmlElem(self.device, None, ['address'])
Line 1196:         card.setAttribute('mode', self.specParams['mode'])
Line 1197:         card.setAttribute('type', self.specParams['type'])
This 'type' attribute, is what the second parameter of createXmlElem is for
Line 1198:         return card
Line 1199: 
Line 1200: 
Line 1201: class RedirDevice(LibvirtVmDevice):


--
To view, visit http://gerrit.ovirt.org/8450
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cdaef420c8381d588f6215e66e6a80dd9d2e44b
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list