Change in vdsm[master]: Online check ksmState and ksmPages.

danken at redhat.com danken at redhat.com
Sat Dec 8 13:16:49 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Online check ksmState and ksmPages.
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/API.py
Line 1126:             stats['momStatus'] = self._cif.mom.getStatus()
Line 1127:             stats.update(self._cif.mom.getKsmStats())
Line 1128:         else:
Line 1129:             stats['momStatus'] = 'disabled'
Line 1130:             stats['ksmState'] = self._cif.running()
are you sure this has been tested? clientIF does not have a "running" method.
Line 1131:             stats['ksmPages'] = self._cif.npages()
Line 1132:             stats['ksmCpu'] = self._cif.ksmMonitor.cpuUsage
Line 1133:             stats['memShared'] = self._memShared() / Mbytes
Line 1134: 


--
To view, visit http://gerrit.ovirt.org/9510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list