Change in vdsm[master]: cpu mode support for vdsm

danken at redhat.com danken at redhat.com
Fri Dec 7 14:12:06 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: cpu mode support for vdsm
......................................................................


Patch Set 4: Looks good to me, approved

(2 inline comments)

....................................................
File tests/libvirtvmTests.py
Line 145:               <model>Opteron_G4</model>
Line 146:               <feature name="sse4.1" policy="require"/>
Line 147:               <feature name="sse4.2" policy="require"/>
Line 148:               <feature name="svm" policy="disable"/>
Line 149:               <topology cores="2" sockets="2" threads="2"/>
who cared about this ordering? I do not.
Line 150:           </cpu> """
Line 151:         cputuneXML = """
Line 152:           <cputune>
Line 153:               <vcpupin cpuset="2-3" vcpu="1"/>


....................................................
File vdsm/libvirtvm.py
Line 726:             cpu.setAttribute('mode', 'host-passthrough')
Line 727:         elif model == 'hostModel':
Line 728:             cpu.setAttribute('mode', 'host-model')
Line 729:         else:
Line 730:             m = self.doc.createElement('model')
heh, a gerrit bug does not show the fixed indentation.
Line 731:             m.appendChild(self.doc.createTextNode(model))
Line 732:             cpu.appendChild(m)
Line 733: 
Line 734:             # This hack is for backward compatibility as the libvirt


--
To view, visit http://gerrit.ovirt.org/9507
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54fb440ef52255f0a7933b000b9b599c2d056021
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list