Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

danken at redhat.com danken at redhat.com
Thu Dec 6 20:59:42 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: netwiring: [3/4] Add cli entry point.
......................................................................


Patch Set 10: (1 inline comment)

....................................................
File vdsm_cli/vdsClient.py
Line 1750:                             'devicespec parameters list: r=required, '
Line 1751:                             'o=optional',
Line 1752:                             'r   devicetype: interface',
Line 1753:                             'o   network: network name - No chage if not '
Line 1754:                             'specified. Dummy bridge and link inactive if '
ShaoHe, I do not understand your request. In my opinion, pep8 fixes are asynchronous to the general development.
Line 1755:                             'empty string',
Line 1756:                             'o   linkActive: bool - No change if not '
Line 1757:                             'specified',
Line 1758:                             'r   alias: libvirt\'s vnic alias',


--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list