Change in vdsm[master]: Adding check of os.access to vdsm log file during startup

ybronhei at redhat.com ybronhei at redhat.com
Thu Dec 6 13:02:34 UTC 2012


Yaniv Bronhaim has posted comments on this change.

Change subject: Adding check of os.access to vdsm log file during startup
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/vdsm
Line 112: 
Line 113: 
Line 114: def __assertLogPermission():
Line 115:     logfile = constants.P_VDSM_LOG + "vdsm.log"
Line 116:     assert(os.access(logfile, os.W_OK), "error in accessing vdsm log file")
You right.. it doesn't make sense to check only this log. maybe I should modify the commit message. 
The patch comes to answer for the bz - https://bugzilla.redhat.com/show_bug.cgi?id=870139

Due to problem with using su (as mention here http://gerrit.ovirt.org/#/c/9118/) I added this patch.
I'm not sure if someone else verifies accessibility to those logs that you've mentioned, but if not, someone should add rfc for that. here I just added what the bz asked for.
Line 117: 
Line 118: 
Line 119: def __assertVdsmUser():
Line 120:     username = getpass.getuser()


--
To view, visit http://gerrit.ovirt.org/9700
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I578bdfaa199afc2d5f154a1de12241e02b1ca1a4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list