Change in vdsm[master]: Check that underlying filesystem supports direct IO before c...
danken at redhat.com
danken at redhat.com
Thu Dec 6 09:47:38 UTC 2012
Dan Kenigsberg has posted comments on this change.
Change subject: Check that underlying filesystem supports direct IO before creating a domain on it
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/fileSD.py
Line 133: self.remotePath = os.path.basename(self.mountpoint)
Line 134: self.metafile = os.path.join(domainPath, sd.DOMAIN_META_DATA,
Line 135: sd.METADATA)
Line 136:
Line 137: self.validateFileSystemFeatures()
why is this required, when we avoid O_DIRECT for such paths?
Line 138:
Line 139: metadata = FileSDMetadata(self.metafile)
Line 140: sdUUID = metadata[sd.DMDK_SDUUID]
Line 141: domaindir = os.path.join(self.mountpoint, sdUUID)
--
To view, visit http://gerrit.ovirt.org/9749
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf14d1c4737a88e693e5bebb896aef382b8b424c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list