Change in vdsm[master]: upgrade: reallocate the metadata slots when needed

fsimonce at redhat.com fsimonce at redhat.com
Wed Dec 5 22:20:23 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: upgrade: reallocate the metadata slots when needed
......................................................................


Patch Set 6: (1 inline comment)

....................................................
File vdsm/storage/imageRepository/formatConverter.py
Line 156: 
Line 157:             if metaOffset < metaMaxSlot:
Line 158:                 continue
Line 159: 
Line 160:             log.debug("Reallocating metadata slot %s for volume %s",
Please consider that it's log.debug. Try to run any software with debugging enabled and look at how much output (aka "useless junk") you'll get.
Line 161:                       metaOffset, vol.volUUID)
Line 162:             metaContent = vol.getMetadata()
Line 163: 
Line 164:             with vol._tagCreateLock:


--
To view, visit http://gerrit.ovirt.org/9660
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15b6a85969a10b5e2b852031fc510aabcc2d5276
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list