Change in vdsm[master]: Do not fail when getVSize is called on an inctive LV.

danken at redhat.com danken at redhat.com
Wed Dec 5 19:06:37 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Do not fail when getVSize is called on an inctive LV.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/blockVolume.py
Line 96:             if e.errno == os.errno.ENOENT:
Line 97:                 # Inactive volume has no /dev entry. Fallback to lvm way.
Line 98:                 size = int(int(lvm.getLV(sdobj.sdUUID, volUUID).size) / bs)
Line 99:             else:
Line 100:                 cls.log.warn("Could not get size for vol %s/%s",
I prefer your version of the code, but I see no reason in spamming the log with this exc_info: whatever calls this method would log it when it catches the re-raise exception.
Line 101:                                 sdobj.sdUUID, volUUID, exc_info=True)
Line 102:                 raise
Line 103: 
Line 104:         return size


--
To view, visit http://gerrit.ovirt.org/9739
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a8b6da4d57cdf810769586c1959989d7a545d0c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list