Change in vdsm[master]: dd: use iflag=direct only when supported by the os

danken at redhat.com danken at redhat.com
Wed Dec 5 18:46:40 UTC 2012


Dan Kenigsberg has submitted this change and it was merged.

Change subject: dd: use iflag=direct only when supported by the os
......................................................................


dd: use iflag=direct only when supported by the os

Much like as vdsm's use of fileUtils.DirectFile that was fixed in
http://gerrit.ovirt.org/9595, we should not pass the "direct" flag to
/bin/dd when the underlying filesystem does not support it.

Change-Id: I76f3ac6a9c220e34f78d0d922145bca56ee8e10e
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/storage/fileUtils.py
M vdsm/storage/misc.py
2 files changed, 24 insertions(+), 10 deletions(-)

Approvals:
  Adam Litke: Looks good to me, but someone else must approve
  Shu Ming: Looks good to me, but someone else must approve
  Saggi Mizrahi: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/9661
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I76f3ac6a9c220e34f78d0d922145bca56ee8e10e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list