Change in vdsm[master]: Move hsm.validatePoolSD() -> pool.validatePoolSD().

ykaplan at redhat.com ykaplan at redhat.com
Wed Dec 5 14:50:33 UTC 2012


Yeela Kaplan has posted comments on this change.

Change subject: Move hsm.validatePoolSD() -> pool.validatePoolSD().
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/storage/sp.py
Line 456:     def getMasterVersion(self):
Line 457:         return self.getMetaParam(PMDK_MASTER_VER)
Line 458: 
Line 459:     # TODO: Remove or rename this function.
Line 460:     def validatePoolSD(self, sdUUID):
Please explain why you don't need the @unsecured
Line 461:         if sdUUID not in self.getDomains():
Line 462:             raise se.StorageDomainNotMemberOfPool(self.spUUID, sdUUID)
Line 463:         return True
Line 464: 


--
To view, visit http://gerrit.ovirt.org/9455
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ba16c8a427c9478ae81c2693d79b8bd601f1ec3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list