Change in vdsm[master]: Specify the ACPI flag when shutting down VMs

danken at redhat.com danken at redhat.com
Wed Dec 5 13:27:27 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Specify the ACPI flag when shutting down VMs
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 1996:                                   blockDevAlias, d.domainID, d.volumeID, err,
Line 1997:                                   physical, alloc)
Line 1998:                     self._lvExtend(d.name)
Line 1999: 
Line 2000:     def _acpiShutdown(self):
I have a feeling that preferring guest-agent shutdown is a remnant from the days where we had guests that did not support acpi. Now they are very rare, and the guest-agent can do its shutting-down stuff when it senses ACPI_POWER_BTN pressed.
Line 2001:         self._dom.shutdownFlags(libvirt.VIR_DOMAIN_SHUTDOWN_ACPI_POWER_BTN)
Line 2002: 
Line 2003:     def _getPid(self):
Line 2004:         pid = '0'


--
To view, visit http://gerrit.ovirt.org/6996
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ca628ce6f4a5c7f6a937a14b12a5078b32e89dd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Bing Bu Cao <mars at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Leonid Natapov <leonidnatapov at gmail.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list