Change in vdsm[master]: cpu mode support for vdsm

lvroyce at linux.vnet.ibm.com lvroyce at linux.vnet.ibm.com
Wed Dec 5 06:06:25 UTC 2012


Royce Lv has posted comments on this change.

Change subject: cpu mode support for vdsm
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 719: 
Line 720:         features = self.conf.get('cpuType', 'qemu64').split(',')
Line 721:         model = features[0]
Line 722:         cpu = self.doc.createElement('cpu')
Line 723:         cpu.setAttribute('match', 'exact')
I mean, quote from http://libvirt.org/formatdomain.html#elementsCPU "host-model"--"Neither match attribute nor any feature elements can be used in this mode"

So 
<cpu match="exact" mode="host-model">
    <topology cores="1" sockets="2" threads="1"/>
</cpu>

is not right according to libvirt document, and this is what the xml will be like when 'model'=='host-model'
Line 724: 
Line 725:         #and now for something completely different
Line 726:         if model == 'hostPassthrough':
Line 727:             cpu.setAttribute('mode', 'host-passthrough')


--
To view, visit http://gerrit.ovirt.org/9507
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54fb440ef52255f0a7933b000b9b599c2d056021
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list