Change in vdsm[master]: Don't fail silently when ifup fails.

asegurap at redhat.com asegurap at redhat.com
Tue Dec 4 22:20:39 UTC 2012


Antoni Segura Puimedon has posted comments on this change.

Change subject: Don't fail silently when ifup fails.
......................................................................


Patch Set 10: (1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 911: 
Line 912:     # Validation
Line 913:     if not utils.tobool(force):
Line 914:         logging.debug('validating network...')
Line 915:         _addNetworkValidation(
Sorry. flake8 was making me cringe so long that I finally gave in and changed it. For another time I'll make it into two patches.
Line 916:             _netinfo, network=network, vlan=vlan, bonding=bonding, nics=nics,
Line 917:             ipaddr=ipaddr, netmask=netmask, gateway=gateway,
Line 918:             bondingOptions=bondingOptions, bridged=bridged, **options)
Line 919: 


--
To view, visit http://gerrit.ovirt.org/8415
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cc9dcc0a6b55d36fc937e1d364bd9c256ecd70a
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list