Change in vdsm[master]: Move hsm.validatePoolSD() -> pool.validatePoolSD().

ykaplan at redhat.com ykaplan at redhat.com
Tue Dec 4 15:28:01 UTC 2012


Yeela Kaplan has posted comments on this change.

Change subject: Move hsm.validatePoolSD() -> pool.validatePoolSD().
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/sp.py
Line 471:             self.validatePoolSD(dom.sdUUID)
Line 472:         except se.StorageDomainNotMemberOfPool:
Line 473:             # TODO: Remove this exception translation. Misleading.
Line 474:             raise se.StorageDomainNotInPool(self.spUUID, dom.sdUUID)
Line 475: 
Please add a comment in storage_exception.py that clarifies the difference between DomainNotInPool and DomainNotMemberOfPool.
Line 476:         pools = dom.getPools()
Line 477:         if self.spUUID not in pools:
Line 478:             raise se.StorageDomainNotInPool(self.spUUID, dom.sdUUID)
Line 479: 


--
To view, visit http://gerrit.ovirt.org/9455
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ba16c8a427c9478ae81c2693d79b8bd601f1ec3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list