Change in vdsm[master]: Don't fail silently when ifup fails.

asegurap at redhat.com asegurap at redhat.com
Tue Dec 4 14:41:52 UTC 2012


Antoni Segura Puimedon has posted comments on this change.

Change subject: Don't fail silently when ifup fails.
......................................................................


Patch Set 9: (1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 1013:         ifup(iface, vlanBootproto == 'dhcp' and not blockingDhcp,
Line 1014:              libvirtNetworkCreation)
Line 1015: 
Line 1016:     if bridged:
Line 1017:         ifup(network, bridgeBootproto == 'dhcp' and not blockingDhcp,
@Dan I hadn't forgotten. With static ip, there is an exception if rc!=0. Codepath:
line 1017->66->79->86->87->68->69->71->74
Line 1018:              libvirtNetworkCreation)
Line 1019: 
Line 1020:     # add libvirt network
Line 1021:     if not async:


--
To view, visit http://gerrit.ovirt.org/8415
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cc9dcc0a6b55d36fc937e1d364bd9c256ecd70a
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list