Change in vdsm[master]: Don't fail silently when ifup fails.

asegurap at redhat.com asegurap at redhat.com
Tue Dec 4 12:50:03 UTC 2012


Antoni Segura Puimedon has posted comments on this change.

Change subject: Don't fail silently when ifup fails.
......................................................................


Patch Set 8:

I made some fixes as noted by the reviewers. The complaints yet to address are:

- Remove the callback mechanism to avoid creating libvirt networks at an unpredictable time.
# I replied my opinion to this: "I think it is better to avoid creating libvirt networks on interfaces that may not be created than it is to avoid having them created when and if the interfaces are successfully created.

- The check still can't change the result returned to engine for the case of dhcp. So I think it doesn't resolve the problem thoroughly.
# I replied: there is no way asynchronous will be reported unless we do some pushing mode. However, I believe that with this change an error will be reported in the logs, the network will not be reported back to the engine (it could be improved by rolling back the part that was created if some was) neither will it be created in libvirt, fixing the recreation problem presented in the bug.

--
To view, visit http://gerrit.ovirt.org/8415
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cc9dcc0a6b55d36fc937e1d364bd9c256ecd70a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list