Change in vdsm[master]: [WIP] Add virtual HTTP(s) server multiplexing port 54321

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Tue Dec 4 06:37:05 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: [WIP] Add virtual HTTP(s) server multiplexing port 54321
......................................................................


Patch Set 1: (1 inline comment)

....................................................
Commit Message
Line 27:   --private-key=/etc/pki/vdsm/keys/vdsmkey.pem \
Line 28:   --ca-certificate=/etc/pki/vdsm/certs/cacert.pem \
Line 29:   https://localhost:54321/etc/vdsm/vdsm.conf
Line 30: When ssl = false
Line 31:   wget http://localhost:54321/etc/vdsm/vdsm.conf
If you have a look at vdsm/BindingXMLRPC.py, you will see in line 145, the is a SimpleHTTPRequestHandler registered for path /etc/vdsm/vdsm.conf.

Only URL that matches the path will get routed to the corresponding handler. So currently you can not download any other files other than /etc/vdsm/vdsm.conf .

Next I can extend this patch to match a path pattern, for example, register a http handler for /temp/coredumps/*.core , then you can download files from http://localhost:54321/temp/coredumps/xyz.core .

In future patches, we can also rewrite part of a URL. For example, we can map http://localhost:54321/core/xyz.core to /temp/coredumps/xyz.core .

For now, file downloading is just a demo for the several usage of the HTTP virtual server. The main purpose of this patch is to provide HTTP streaming channels for guest serial console.
Line 32: 
Line 33: Change-Id: Ie99bf9353603ae96b0570367e22a01817e5c4e97


--
To view, visit http://gerrit.ovirt.org/9605
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99bf9353603ae96b0570367e22a01817e5c4e97
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list