Change in vdsm[master]: netwiring: [2/4] Add API definitions.

shaohef at linux.vnet.ibm.com shaohef at linux.vnet.ibm.com
Mon Dec 3 17:05:15 UTC 2012


ShaoHe Feng has posted comments on this change.

Change subject: netwiring: [2/4] Add API definitions.
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

Hopefully, my patch can be merged. http://gerrit.ovirt.org/#/c/9433/

 it is easy to find the minor error.

....................................................
File vdsm_api/vdsmapi-schema.json
Line 4867:  'data': {'deviceType': 'VmDeviceType'},
Line 4868:  'union': ['vmUpdateInterfaceDeviceParams']}
Line 4869: 
Line 4870: ##
Line 4871: # @vmUpdateIntefaceDeviceParams:
vmUpdateInterfaceDeviceParams?
 Inte --> Inter ?
Line 4872: #
Line 4873: # Parameters for @VM.updateDevice
Line 4874: #
Line 4875: # @alias:         Alias used to identify this device in commands.


--
To view, visit http://gerrit.ovirt.org/9560
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d8352f237dbe0229dff368f7c1dfa4f5f8fc766
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list