Change in vdsm[master]: vdsmd.init: drop check_port_taken

danken at redhat.com danken at redhat.com
Mon Dec 3 10:14:30 UTC 2012


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsmd.init: drop check_port_taken
......................................................................


vdsmd.init: drop check_port_taken

net-tools is not installed on F18 by default, and was obsoleted by
iproute a decade ago. This is a good opportunity to drop the whole
check_port_taken attempt from the daemon startup. This check is
inherently raceful, it was applied only to the the xmlrpc port (even if
jsonrpc is used), and is utterly unhelpful if we're using systemd (that
reports error to system log, just like vdsm.log).

Change-Id: I8417ae3bb2f09404787cd8915984aaa6fb779e7a
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/vdsmd.init.in
1 file changed, 0 insertions(+), 18 deletions(-)

Approvals:
  Alon Bar-Lev: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/9651
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8417ae3bb2f09404787cd8915984aaa6fb779e7a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>


More information about the vdsm-patches mailing list