Change in vdsm[master]: fix error handling for misc.NoIntrPoll

danken at redhat.com danken at redhat.com
Mon Dec 3 07:44:35 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: fix error handling for misc.NoIntrPoll
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

minor comment. other than that, I'm good.

....................................................
File tests/miscTests.py
Line 1152:         poller.unregister(fd)
Line 1153: 
Line 1154:     def testWatchFile(self):
Line 1155:         try:
Line 1156:             tempFd, tempPath = tempfile.mkstemp()
"try" should be put right after tempPath has been created, not before it - in case mkstemp() fails.

In this particular case, rmFile would swallow the error, but this is bad practice.
Line 1157:             self._startFakeSigchld()
Line 1158:             # only poll can support regular file
Line 1159:             self._noIntrWatchFd(tempFd, isEpoll=False)
Line 1160:         finally:


--
To view, visit http://gerrit.ovirt.org/9458
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I272654a9006fdab77e5fab608ac287416d75843e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list