Change in vdsm[master]: pep8: more semi-automatic fixes

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Mon Dec 3 02:38:38 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: pep8: more semi-automatic fixes
......................................................................


Patch Set 1: Verified; I would prefer that you didn't submit this

(2 inline comments)

Pass autobuild.sh and pydiff.

Since it's a semi-automatic fix,  some files are not 100% clean, so I only do a rough review. -1 for two small problems.

....................................................
File vdsm/storage/iscsi.py
Line 246: 
Line 247: # Technically there are a lot more interface properties but VDSM doesn't
Line 248: 
Line 249: 
Line 250: # support them at the moment
Blank lines should be added above the block comment, not in the block comment.
Line 251: class IscsiInterface(object):
Line 252: 
Line 253:     _fields = {
Line 254:             "name": ('iface.iscsi_ifacename', 'rw'),


....................................................
File vdsm/storage/sp.py
Line 1425
Line 1426
Line 1427
Line 1428
Line 1429
Why remove this comment?


--
To view, visit http://gerrit.ovirt.org/9606
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbb36be20c77f714246279d1ae9067353bced047
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list