Change in vdsm[master]: Adding monkeyPatch that replaces _start function of superVds...

danken at redhat.com danken at redhat.com
Sun Dec 2 15:21:46 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Adding monkeyPatch that replaces _start function of superVdsmProxy for tests
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File tests/superVdsmTests.py
Line 16:     base = os.path.dirname(testDir)
Line 17:     vdsmPath = os.path.join(base, 'vdsm')
Line 18:     cliPath = os.path.join(base, 'vdsm_cli')
Line 19:     pyPath = "PYTHONPATH=" + base
Line 20:     for p in [vdsmPath, cliPath]:
sounds like ':'.join()
Line 21:         pyPath = pyPath + ":" + p
Line 22:     yield pyPath
Line 23: 
Line 24: 


Line 18:     cliPath = os.path.join(base, 'vdsm_cli')
Line 19:     pyPath = "PYTHONPATH=" + base
Line 20:     for p in [vdsmPath, cliPath]:
Line 21:         pyPath = pyPath + ":" + p
Line 22:     yield pyPath
why do you want a generator with a single element?
Line 23: 
Line 24: 
Line 25: def monkeyStart(self):
Line 26:     self._authkey = str(uuid.uuid4())


--
To view, visit http://gerrit.ovirt.org/9643
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94668b165fa858221899698f0679fff8eb5e2223
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list