Change in vdsm[master]: Move fenceNode out of API.py

danken at redhat.com danken at redhat.com
Fri Aug 31 20:09:32 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Move fenceNode out of API.py
......................................................................


Patch Set 7: I would prefer that you didn't submit this

(1 inline comment)

....................................................
Commit Message
Line 5: CommitDate: 2012-08-27 11:16:03 -0400
Line 6: 
Line 7: Move fenceNode out of API.py
Line 8: 
Line 9: The actual details of how the response is mangles is part of the
mangles->mangled

Understood. But why fenceNode is completely obliterated from API.py? it is still a public verb, so it should still be exposed to the world via API.

It may be a silly

 fenceNode = fenceAgent=fenceNode

but as long as we keep API.py, all public verbs should be there.
Line 10: bindings so API.py really doesn't serve a purpose.
Line 11: 
Line 12: This is the first step in a general trend of moving the logic out of
Line 13: API.py to dedicated modules and move the response mangling to the


--
To view, visit http://gerrit.ovirt.org/7191
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idaba551333a0f289abaff11dc113e09c426d591a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list