Change in vdsm[master]: Move load_needed_modules to vdsm-tool

wenyi at linux.vnet.ibm.com wenyi at linux.vnet.ibm.com
Fri Aug 31 14:36:04 UTC 2012


Wenyi Gao has posted comments on this change.

Change subject: Move load_needed_modules to vdsm-tool
......................................................................


Patch Set 5: No score

(1 inline comment)

....................................................
File vdsm-tool/load_needed_modules.py.in
Line 44:                              stderr=subprocess.PIPE)
Line 45:         out, err = p.communicate()
Line 46:         rc = p.returncode
Line 47:     except:
Line 48:         logging.error(traceback.format_exc())
The load_needed_modules.py is installed in python/site-packagesvdsm/tool. However execCmd in vdsm.utils requires an implementation that is outside site-packages. In fact execCmd is actually implemented in misc is installed in /usr/share/vdsm/stroage/.
Line 49: 
Line 50:     return (rc, out, err)
Line 51: 
Line 52: 


--
To view, visit http://gerrit.ovirt.org/7487
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icdc8f9d07a7150c4a846228811d6c5dcb17fa358
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list