Change in vdsm[master]: Added _execGlusterXml()

danken at redhat.com danken at redhat.com
Thu Aug 30 22:24:36 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Added _execGlusterXml()
......................................................................


Patch Set 6: (1 inline comment)

....................................................
File vdsm/gluster/cli.py
Line 78:         msg = tree.find('opErrstr').text
Line 79:     except (etree.ParseError, AttributeError):
Line 80:         raise ge.GlusterXmlErrorException(err=out)
Line 81:     if rv == '0':
Line 82:         return (tree, out)
Bala: "Unfortunately, its not possible to convert cElementTree object to string. So cli output in xml is passed to command specific functions."

why etree.tostring(tree) is not good enough for the rare cases you need the string?
Line 83:     else:
Line 84:         raise ge.GlusterCmdFailedException(rc=rv, err=[msg])
Line 85: 
Line 86: 


--
To view, visit http://gerrit.ovirt.org/6999
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I385f992005d446b417be84eb7ff484e4edf6e5b6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list