Change in vdsm[master]: bootstrap: survive missing ntpq

danken at redhat.com danken at redhat.com
Thu Aug 30 09:48:32 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: bootstrap: survive missing ntpq
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm_reg/deployUtil.py.in
Line 693: 
Line 694:     out = ""
Line 695:     if os.path.exists(EX_NTPQ):
Line 696:         out, err, rc = _logExec([EX_NTPQ, "-c", "rv"])
Line 697:     if 'clock_sync' in out:
I think a slightly safer (works for other failures to run ntpq) and even smaller(!) way would be

  if out and 'clock_sync' in out:
Line 698:         logging.debug("setHostTime: Time is synchronised to NTP server.")
Line 699:     else:
Line 700:         try:
Line 701:             ttp = time.strptime(VDCTime, '%Y-%m-%dT%H:%M:%S')


--
To view, visit http://gerrit.ovirt.org/7597
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list