Change in vdsm[master]: Define network filter on libvirt

ilvovsky at redhat.com ilvovsky at redhat.com
Wed Aug 29 11:58:56 UTC 2012


Igor Lvovsky has posted comments on this change.

Change subject: Define network filter on libvirt
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File vdsm/nwfilter.py
Line 59:             # Failure might occur when attempting to remove a filter which
Line 60:             # is being used by running VMs
Line 61:             pass
Line 62: 
Line 63:         nwFilter = conn.nwfilterDefineXML(self.buildFilterXml())
Is this will work if filter already defined and you swallowed the exception in lines above?
Line 64:         logging.debug("Filter %s was defined" % nwFilter.name())
Line 65: 
Line 66: 
Line 67: class NoMacSpoofingFilter(NwFilter):


--
To view, visit http://gerrit.ovirt.org/7354
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1708385dec6a87bc404e4ab25c4da8ab8a8acc
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list